Fix vote handler rejecting valid votes due to concurrent#527
Open
walterzhaoJR wants to merge 1 commit intobaidu:masterfrom
Open
Fix vote handler rejecting valid votes due to concurrent#527walterzhaoJR wants to merge 1 commit intobaidu:masterfrom
walterzhaoJR wants to merge 1 commit intobaidu:masterfrom
Conversation
Fix vote handler rejecting valid votes due to concurrent In handle_request_vote_request, the mutex is released to fetch last_log_id (blocking I/O). During this unlock window, a concurrent heartbeat response with a higher term can trigger step_down, advancing _current_term. The original ABA check unconditionally rejected the vote when _current_term changed, even if the vote request was still valid for the new term. Refine the ABA check to only reject votes when _current_term has surpassed request->term() (vote is stale). If term changed but request->term() is still >= new term, update saved_current_term and continue processing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix vote handler rejecting valid votes due to concurrent
In handle_request_vote_request, the mutex is released to fetch last_log_id (blocking I/O). During this unlock window, a concurrent heartbeat response with a higher term can trigger step_down, advancing _current_term. The original ABA check unconditionally rejected the vote when _current_term changed, even if the vote request was still valid for the new term.
Refine the ABA check to only reject votes when _current_term has surpassed request->term() (vote is stale). If term changed but request->term() is still >= new term, update saved_current_term and continue processing.
detail：#526